Skip to content

Conversation

@Hou-Rui
Copy link
Contributor

@Hou-Rui Hou-Rui commented Apr 13, 2020

Add import syntax to js-slang to use modules.
This branch is based on a very old version of js-slang and thus need manual mergings.

@coveralls
Copy link

coveralls commented Apr 13, 2020

Pull Request Test Coverage Report for Build 2868

  • 64 of 85 (75.29%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 87.896%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/moduleLoader.ts 16 18 88.89%
src/errors/errors.ts 6 10 60.0%
src/transpiler/transpiler.ts 30 36 83.33%
src/interpreter/interpreter.ts 12 21 57.14%
Totals Coverage Status
Change from base Build 2853: -0.2%
Covered Lines: 5049
Relevant Lines: 5536

💛 - Coveralls

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive advised the non-det team to avoid the confusing term "hoist" in their implementation in src/interpreter/interpreter-non-det.ts
So for example hoistVariableDeclarations will just become declareVariables etc.
Can you please change interpreter.ts accordingly? Thanks.

@Hou-Rui
Copy link
Contributor Author

Hou-Rui commented Apr 13, 2020

Ive advised the non-det team to avoid the confusing term "hoist" in their implementation in src/interpreter/interpreter-non-det.ts
So for example hoistVariableDeclarations will just become declareVariables etc.
Can you please change interpreter.ts accordingly? Thanks.

Okay, changes committed.

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@Hou-Rui Hou-Rui merged commit 56252ea into master Apr 13, 2020
@thomastanck thomastanck deleted the module-support branch August 1, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants