Skip to content

Misc Improvements 3#525

Merged
RichDom2185 merged 54 commits intomasterfrom
plugins
Feb 14, 2026
Merged

Misc Improvements 3#525
RichDom2185 merged 54 commits intomasterfrom
plugins

Conversation

@leeyi45
Copy link
Contributor

@leeyi45 leeyi45 commented Jan 10, 2026

PR for a bunch of miscellaneous changes focused mainly around improving documentation.

  1. Type guards have their return types rendered as boolean in the documentation so as not to confuse cadets
  2. Code examples are validated via parser and ESLint to ensure that we don't get invalid code for code examples (closes Investigate Better Documentation Verification #522)
  3. Separate the two tsc functions into two different commands
  4. Fix markdown tree plugin not rendering certain examples correctly
  5. Update documentation
  6. Fix certain packages not having the correct lodash dependency declared
  7. Update to v6 for @blueprintjs
  8. Add validation for checking the number of parameters that take callbacks (closes Parameter Validation for Callback functions passed to bundles #560)

# Conflicts:
#	lib/buildtools/src/build/__tests__/all.test.ts
#	lib/lintplugin/package.json
#	lib/modules-lib/src/tabs/__tests__/useAnimation.test.ts
#	package.json
#	yarn.lock
Comment on lines -56 to 66
g: number,
b: number
): Point {
r = clamp(r, 0, 255);
g = clamp(g, 0, 255);
b = clamp(b, 0, 255);

return new Point(x, y, 0, [r / 255, g / 255, b / 255, 1]);
}
export const make_color_point = CurveFunctions.make_color_point;

/**

This comment was marked as outdated.

Comment on lines +378 to +384
drawer: RenderFunction,
func: CurveAnimation
): AnimatedCurve {
if (drawer.is3D) {
throw new Error(`${animate_curve.name} cannot be used with 3D draw function!`);
}

This comment was marked as outdated.

Comment on lines -257 to -263
const mat = [
[
cthz * cthy,
cthz * sthy * sthx - sthz * cthx,
cthz * sthy * cthx + sthz * sthx
],
[

This comment was marked as outdated.

@leeyi45 leeyi45 changed the title Documentation Improvements Misc Improvements 3 Feb 13, 2026
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@RichDom2185 RichDom2185 enabled auto-merge (squash) February 14, 2026 16:57
@RichDom2185 RichDom2185 merged commit 9100d1c into master Feb 14, 2026
71 checks passed
@RichDom2185 RichDom2185 deleted the plugins branch February 14, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parameter Validation for Callback functions passed to bundles Investigate Better Documentation Verification

2 participants