-
Notifications
You must be signed in to change notification settings - Fork 134
Finalising images #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalising images #578
Conversation
2.9-2.12, 2.14
|
For figure 2.15: That's a huge improvement. SICP's picture is really ugly. However, frame1 and frame2 don't appear in the text in this way. They shouldn't be code font, because SICP didn't say edge1-frame. I think we should render the words as in the formula: Origin(Frame)+x· Edge1 (Frame)+y· Edge2 (Frame) That means: |
Looks fine now. |
It's fine. |
|
Addressed everything now! Please take a look to see it is OK. |
|
Before this is merged I will address Julie's comment on the ellipsis! |
|
Ellipses done! |
martin-henz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good



Finalizing all images EXCEPT 2.9-2.12, 2.14 (Rogers and wavy).
This includes:
Questions/comments:
SICP 2e has all the text of Figure 2.15 in code font, we have it all in
text font. Since the names don't necessarily refer to elements in code,
but concepts, I feel text font is better. Input?
Figure 3.31 might have become a little too tight in the leftmost
triangle -- or will it do?
I left a ... in Figure 5.14 NOT as an ellipsis because it wasn't code
and it looked terrible with an ellipsis character.