Skip to content

Conversation

@TobiasWrigstad
Copy link
Collaborator

Finalizing all images EXCEPT 2.9-2.12, 2.14 (Rogers and wavy).

This includes:

  • Colors of lines
  • Font sizes
  • Figure sizes (left unchanged except for relative size changes inside wrt text)

Questions/comments:

SICP 2e has all the text of Figure 2.15 in code font, we have it all in
text font. Since the names don't necessarily refer to elements in code,
but concepts, I feel text font is better. Input?

Figure 3.31 might have become a little too tight in the leftmost
triangle -- or will it do?

I left a ... in Figure 5.14 NOT as an ellipsis because it wasn't code
and it looked terrible with an ellipsis character.

@martin-henz
Copy link
Member

For figure 2.15: That's a huge improvement. SICP's picture is really ugly.

However, frame1 and frame2 don't appear in the text in this way. They shouldn't be code font, because SICP didn't say edge1-frame. I think we should render the words as in the formula:

Origin(Frame)+x· Edge1 (Frame)+y· Edge2 (Frame)

That means:
frame => Frame (three times)
edge1 => Edge1 (with subscript 1)
edge2 => Edge2 (with subscript 2)
origin => Origin

@martin-henz
Copy link
Member

I left a ... in Figure 5.14 NOT as an ellipsis because it wasn't code
and it looked terrible with an ellipsis character.

Looks fine now.

@martin-henz
Copy link
Member

Figure 3.31 might have become a little too tight in the leftmost
triangle -- or will it do?

It's fine.

@martin-henz
Copy link
Member

Screenshot 2021-07-22 at 8 15 55 AM

base e and exponent iA are too close together

@martin-henz
Copy link
Member

Screenshot 2021-07-22 at 8 19 07 AM

Can we use the same font as in the text?

@martin-henz
Copy link
Member

Screenshot 2021-07-22 at 8 37 02 AM

The horizonal line should connect to the dot, see SICP.

@TobiasWrigstad
Copy link
Collaborator Author

Addressed everything now! Please take a look to see it is OK.

@TobiasWrigstad
Copy link
Collaborator Author

Before this is merged I will address Julie's comment on the ellipsis!

@TobiasWrigstad
Copy link
Collaborator Author

Ellipses done!

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@martin-henz martin-henz merged commit 823e613 into master Jul 22, 2021
@RichDom2185 RichDom2185 deleted the finalising-images branch July 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants