fix(logging): only log server errors, remove unnecessary details from logs #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
previously approved these changes
May 29, 2025
src/utils/errors.rs
Outdated
| SourceRepositoryMissingPrimaryMirror, | ||
|
|
||
| #[error("object not found: {0:?}")] | ||
| #[error("object not found: {message}", message = .0.as_ref().unwrap_or(&"".to_string()))] |
Contributor
There was a problem hiding this comment.
Could maybe use unwrap_or_default?
alukach
changed the title
alukach
pushed a commit
that referenced
this pull request
May 29, 2025
🤖 I have created a release *beep* *boop* --- ## [0.1.29](v0.1.28...v0.1.29) (2025-05-29) ### Bug Fixes * **errors:** pass through client error status codes ([#77](#77)) ([fe383dd](fe383dd)) * **logging:** only log server errors, remove unnecessary details from logs ([#75](#75)) ([496373c](496373c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: source-coop-release[bot] <187876225+source-coop-release[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm changing
Some(...)How I did it
See code...
How to test it
See successful test output...
PR Checklist
and I have opened issue/PR #XXX to track the change.
Related Issues