fix(errors): pass through client error status codes #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm changing
I noticed that when an ApiClientError is thrown (e.g. the source API returns a
401for a private repository), the proxy throws a502gateway error. This obfuscates the underlying error. Instead, we should pass that error through from the proxy.Running into this error
I have a disabled repo at https://source.coop/alukach/test-repo. The API returns a
401when I attempt to access it: https://source.coop/api/v1/repositories/alukach/test-repoHowever, the data proxy currently returns a
502because the401:How I did it
Updated the ResponseError implementation for BackendError to correctly pass through client error status codes from ApiClientError, ensuring that the appropriate status code is returned in the response.
How to test it
PR Checklist
and I have opened issue/PR #XXX to track the change.
Related Issues