Observability/convert error handling #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedsundwall
previously approved these changes
May 13, 2025
jedsundwall
left a comment
jedsundwall
left a comment
There was a problem hiding this comment.
I'm really not qualified to give this a proper review but I'm glad you're doing this.
gadomski
reviewed
May 13, 2025
Comment on lines
+179
to
+183
| impl From<serde_xml_rs::Error> for BackendError { | ||
| fn from(error: serde_xml_rs::Error) -> BackendError { | ||
| BackendError::XmlParseError(format!("failed to parse xml: {}", error)) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This one we could have used thiserror's #[from] macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #
Proposed Changes:
In #58, we introduced
thiserror. When the API is overrun, we are now serving500rather than404responses (which seems more accurate to our needs) but our logs are missing important contextual information as they appear to be from the legacyAPIErrorlogs which lacked some information.This PR:
matchstatements, as we can now throw ourBackendErrorand have it automatically converted to a response via theactix_web::error::ResponseErrortrait, as demonstrated in the Actix guide: https://actix.rs/docs/errors#an-example-of-a-custom-error-responsePR Checklist:
and I have opened issue/PR #XXX to track the change.