fix(web): don't include sources in grep tool when groupByRepo=true#1032
Merged
brendan-kellam merged 2 commits intomainfrom Mar 23, 2026
Merged
Conversation
When `groupByRepo=true`, the LLM only sees a repo-level summary and never references individual files. Previously, all matched files were still streamed to the client as sources, causing 1000+ individual setSources() calls and cascading re-renders that froze the UI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
WalkthroughThe pull request fixes a UI freeze issue that occurred when the grep tool returned large result sets with Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
groupByRepo=true, the grep tool was still including all matched files assourcesin the tool result, even though the LLM only receives a repo-level summary and never references individual filessetSources()state updates to be dispatched to the client, each triggering a full re-render of the chat thread and all message pairssourcesfrom the return value whengroupByRepo=trueTest plan
groupByRepo=trueand confirm the UI no longer freezes when results returnFixes SOU-730
🤖 Generated with Claude Code
Summary by CodeRabbit