Skip to content

fix: Add missing changes from #1170#1176

Merged
brendan-kellam merged 3 commits intomainfrom
bkellam/fix_1170
May 5, 2026
Merged

fix: Add missing changes from #1170#1176
brendan-kellam merged 3 commits intomainfrom
bkellam/fix_1170

Conversation

@brendan-kellam
Copy link
Copy Markdown
Contributor

@brendan-kellam brendan-kellam commented May 5, 2026

Forgot to re-generate the schema for changes introduced in #1170

Summary by CodeRabbit

  • Bug Fixes

    • Azure DevOps connection validation relaxed to allow spaces in project/repository path segments and to accept three-segment repository identifiers.
  • Documentation

    • Updated schema documentation to reflect the relaxed Azure DevOps connection validation rules.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b1302d52-8ac2-43d8-93aa-b832d3f6c1d5

📥 Commits

Reviewing files that changed from the base of the PR and between 5d1ca5c and f47af4a.

📒 Files selected for processing (1)
  • CHANGELOG.md

Walkthrough

This PR relaxes JSON Schema regex validations for AzureDevOps connection identifiers: projects now allows spaces in the second path segment, and repos now allows spaces in the second and third path segments. Schema source files and documentation snippets were updated; a CHANGELOG entry was added.

Changes

Azure DevOps Schema Pattern Relaxation

Layer / File(s) Summary
Data Shape / Schema constraints
packages/schemas/src/v3/connection.schema.ts, packages/schemas/src/v3/index.schema.ts
Added/modified item pattern values for AzureDevOpsConnectionConfig.projects from ^[\\w.-]+\\/[\\w.-]+$^[\\w.-]+\\/[\\w. -]+$ and for AzureDevOpsConnectionConfig.repos from ^[\\w.-]+\\/[\\w.-]+\\/[\\w.-]+$^[\\w.-]+\\/[\\w. -]+\\/[\\w. -]+$.
Documentation / Snippets
docs/snippets/schemas/v3/connection.schema.mdx, docs/snippets/schemas/v3/index.schema.mdx
Updated documentation snippets to reflect the relaxed regex patterns for projects and repos identifiers.
Changelog
CHANGELOG.md
Added Unreleased Fixed bullet noting the missing schema changes introduced in prior PRs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • sourcebot-dev/sourcebot#1170: Makes identical Azure DevOps connection schema pattern changes to allow spaces in project and repository name segments.

Suggested labels

sourcebot-team

Suggested reviewers

  • msukkari
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: Add missing changes from #1170' is vague and does not convey the actual substance of the changes, which involve broadening regex patterns to allow spaces in Azure DevOps path segments. Consider a more descriptive title like 'fix: Allow spaces in Azure DevOps connection paths' that clearly indicates what was actually modified.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/fix_1170

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

This comment has been minimized.

@mintlify
Copy link
Copy Markdown

mintlify Bot commented May 5, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
sourcebot 🟢 Ready View Preview May 5, 2026, 10:25 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@brendan-kellam brendan-kellam merged commit c9cc7e4 into main May 5, 2026
7 checks passed
@brendan-kellam brendan-kellam deleted the bkellam/fix_1170 branch May 5, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant