fix: refresh yarn.lock to upgrade ip-address to ^10.2.0 (CVE-2026-42338)#1189
Merged
brendan-kellam merged 4 commits intomainfrom May 9, 2026
Merged
fix: refresh yarn.lock to upgrade ip-address to ^10.2.0 (CVE-2026-42338)#1189brendan-kellam merged 4 commits intomainfrom
brendan-kellam merged 4 commits intomainfrom
Conversation
Co-authored-by: Brendan Kellam <brendan@sourcebot.dev>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughA single changelog entry documents a transitive ChangesChangelog Security Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Brendan Kellam <brendan@sourcebot.dev>
Contributor
License Audit
Weak Copyleft Packages (informational)
Resolved Packages (19)
|
Replaces the prior socks resolution-override approach with a lockfile refresh. The existing ranges (socks: ^2.8.3 in socks-proxy-agent, express-rate-limit: ^8.2.1 in @modelcontextprotocol/sdk) already admit patched versions; the lockfile was just stale. Removed yarn.lock entries for socks@^2.8.3 and express-rate-limit@^8.2.1, then re-ran yarn install. Resulting lock pins: socks 2.8.4 -> 2.8.9 (ip-address ^9.0.5 -> ^10.1.1) express-rate-limit 8.3.2 -> 8.5.1 (ip-address 10.1.0 -> ^10.2.0) All three ip-address instances in the tree now resolve to 10.2.0 (patched). No package.json change, no resolutions override required. Also fixes the prior PR's incomplete remediation: the express-rate-limit chain still pinned ip-address@10.1.0, which is < 10.1.1 and still vulnerable per the GHSA. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
brendan-kellam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-1031
Summary
Addresses CVE-2026-42338 (XSS in
ip-address< 10.1.1) by refreshing the lockfile entries that pinned vulnerable transitive versions. Nopackage.jsonchange, noresolutionsoverride.Why a lockfile refresh, not a resolution override
yarn why ip-address --recursiveshowed two chains pinning a vulnerable version:@sourcebot/backend → @sentry/profiling-node → … → socks-proxy-agent → socks@2.8.4 → ip-address@9.0.5@sourcebot/web → @modelcontextprotocol/sdk → express-rate-limit@8.3.2 → ip-address@10.1.0(still < 10.1.1, still vulnerable)The existing source ranges in those chains (
socks: ^2.8.3,express-rate-limit: ^8.2.1) already admit patched versions. The lockfile was simply stale — written before the patched versions existed.Per
CLAUDE.mdstep 2 (lockfile refresh before resolution override), the fix is to drop the two stale yarn.lock entries and re-resolve:socks@2.8.4(depsip-address@^9.0.5)socks@2.8.9(depsip-address@^10.1.1)express-rate-limit@8.3.2(depsip-address@10.1.0)express-rate-limit@8.5.1(depsip-address@^10.2.0)Verification
All three instances on the patched 10.2.0.
Note on the prior approach
The prior commits on this branch (a
socksresolution override) only addressed thesockschain — theexpress-rate-limitchain still pinnedip-address@10.1.0, which is< 10.1.1and still vulnerable per the GHSA. This commit replaces that with a complete fix.🤖 Generated with Claude Code
Summary by CodeRabbit