feat(web): restore scroll position when browsing files#1261
Merged
Conversation
The code preview panel now persists the scroll position per file/revision to sessionStorage and restores it on mount. Restoration is skipped when a highlight_range query param is present so the existing highlight scroll-into-view takes precedence. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-1260
Summary
Adds scroll position restoration to the code browser's file preview panel (
pureCodePreviewPanel.tsx). Previously, scrolling down a file, navigating away, and returning would reset you to the top.How it works
ScrollAreaviewport ([data-radix-scroll-area-viewport]), not CodeMirror's internal scroller. The scroll position is captured from there.sessionStorageunder abrowse-scroll-pos:{repoName}@{revisionName}:{path}key, throttled to one write per animation frame.viewport.scrollTo(...)on the next frame so layout has settled.highlight_rangequery param is present, so the existing highlight scroll-into-view behavior takes precedence.Notes
sessionStorage, so positions persist across in-session back/forward and re-navigation but reset when the tab closes.🤖 Generated with Claude Code