fix: set git safe.directory at system level for non-root container users#1262
Merged
Merged
Conversation
Switches the safe.directory "*" config from --global (only written to /root/.gitconfig) to --system (/etc/gitconfig) so it applies regardless of which user runs git. The image intentionally sets no USER directive and can be run as an arbitrary --user, where the global config was never read, leaving the "dubious ownership" error unfixed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the
safe.directory "*"git config in the Dockerfile from--globalto--system.--globalwrites only to the home directory of the build-time user (/root/.gitconfig). The image intentionally sets noUSERdirective (see the comment near the entrypoint) and can be run assourcebotor an arbitrary--userat runtime. In those cases git reads that user's$HOME/.gitconfig, never seessafe.directory, and the "dubious ownership" error this line is meant to prevent still fires.--systemwrites to/etc/gitconfig, which is read by every user regardless of who invokes git, so the fix now actually covers all three run modes (root,sourcebot, arbitrary--user).Risk
Low / net risk reduction:
RUNruns as root at build time, so it can write/etc/gitconfig./etc/gitconfigis created with default umask (644), world-readable, and nothing later chmods/etc, so non-root runtime users can read it.safe.directoryis multi-valued and accumulated across config levels, so the lower-precedence system scope can't be clobbered by a user-level gitconfig.🤖 Generated with Claude Code