Skip to content

refactor(web): share connectors explainer copy across login and upsell menus#1280

Merged
msukkari merged 2 commits into
mainfrom
msukkari/shared-connectors-explainer
Jun 4, 2026
Merged

refactor(web): share connectors explainer copy across login and upsell menus#1280
msukkari merged 2 commits into
mainfrom
msukkari/shared-connectors-explainer

Conversation

@msukkari
Copy link
Copy Markdown
Contributor

@msukkari msukkari commented Jun 4, 2026

Summary by CodeRabbit

  • Refactor
    • Unified connector-related messaging into a shared explainer component for consistent wording and login prompts across the app.
  • Documentation
    • Added an inline “Learn more” link to connector docs from the explainer text.
  • UI
    • Login prompt now shows a clear explainer with a link to sign in and preserved access to the paid-plan upsell.

…l menus

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

@msukkari your pull request is missing a changelog!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e86b8531-3667-4fe1-b12e-5c1e3730714a

📥 Commits

Reviewing files that changed from the base of the PR and between a966012 and 77d26ba.

📒 Files selected for processing (1)
  • packages/web/src/features/chat/components/chatBox/connectorsExplainerText.tsx

Walkthrough

This PR centralizes connectors explainer messaging by adding a shared ConnectorsExplainerText component and switching two consumers to render that component instead of inline explainer markup.

Changes

Connectors Explainer Component Consolidation

Layer / File(s) Summary
Shared component foundation
packages/web/src/features/chat/components/chatBox/connectorsExplainerText.tsx
New ConnectorsExplainerText component exports styled paragraph with optional leading/trailing inline content, a fixed description sentence, and an external "Learn more" link. Module also exports CONNECTORS_DOCS_URL.
Consumer updates
packages/web/src/ee/features/chat/mcp/components/connectorsMenu.tsx, packages/web/src/features/chat/components/chatBox/connectorsExplainerMenu.tsx
Two consuming components updated to use ConnectorsExplainerText. connectorsMenu.tsx replaces its login prompt with the component using a leading prop for the login link and removes the LogInIcon import. connectorsExplainerMenu.tsx replaces its inline explainer paragraph with the component, passing the paid-plan button as trailing and removing the inline docs link.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'refactor(web): share connectors explainer copy across login and upsell menus' accurately describes the main change: extracting shared explainer text into a reusable component and using it across multiple menus.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch msukkari/shared-connectors-explainer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@packages/web/src/features/chat/components/chatBox/connectorsExplainerText.tsx`:
- Around line 4-5: The TODO about finalizing the connectors docs URL is stale:
remove the TODO comment and treat CONNECTORS_DOCS_URL as final by updating or
deleting the "// TODO(ask): finalize the connectors docs URL once the page
exists." comment and ensuring export const CONNECTORS_DOCS_URL =
"https://docs.sourcebot.dev/docs/features/ask/connectors"; remains as the
canonical URL (referencing the CONNECTORS_DOCS_URL symbol in
connectorsExplainerText.tsx).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: da49492a-b60b-44a8-8085-14dbc65883d0

📥 Commits

Reviewing files that changed from the base of the PR and between bd47aab and a966012.

📒 Files selected for processing (3)
  • packages/web/src/ee/features/chat/mcp/components/connectorsMenu.tsx
  • packages/web/src/features/chat/components/chatBox/connectorsExplainerMenu.tsx
  • packages/web/src/features/chat/components/chatBox/connectorsExplainerText.tsx

Comment thread packages/web/src/features/chat/components/chatBox/connectorsExplainerText.tsx Outdated
@msukkari msukkari merged commit 67a88fe into main Jun 4, 2026
6 of 7 checks passed
@msukkari msukkari deleted the msukkari/shared-connectors-explainer branch June 4, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant