-
Notifications
You must be signed in to change notification settings - Fork 225
web(chore): Cleanup me control design #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
|
@coderabbitai review |
|
Caution Review failedThe pull request is closed. WalkthroughRefactors top navigation by replacing SettingsDropdown with focused appearance and account controls, removes Discord/GitHub buttons, shows user avatar in the top bar, moves the version indicator into the "What's new" dropdown, and propagates auth sessions via async page/layout changes. Changes
Sequence DiagramsequenceDiagram
participant Browser as Client Browser
participant Page as Page/Layout (server)
participant Auth as Auth (next-auth)
participant UI as Client UI (LayoutClient / TopBar / Menus)
Browser->>Page: Request page
Page->>Auth: await auth()
Auth-->>Page: session (or null)
Page->>Browser: render with session prop
Browser->>UI: Initialize client components (LayoutClient)
UI->>UI: TopBar receives session
alt session != null
UI->>UI: Render MeControlDropdownMenu (avatar, account menu)
UI->>UI: Render Appearance controls within menu
else session == null
UI->>UI: Render Login button + AppearanceDropdownMenu
end
UI-->>Browser: Render final UI
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Actions performedReview triggered.
|
This PR:
Signed in:


Signed out:



Fixes #820
Summary by CodeRabbit
New Features
Changed
Removed