revert: remove global minimatch resolution that broke glob@10/11#963
Merged
brendan-kellam merged 2 commits intomainfrom Feb 27, 2026
Merged
revert: remove global minimatch resolution that broke glob@10/11#963brendan-kellam merged 2 commits intomainfrom
brendan-kellam merged 2 commits intomainfrom
Conversation
Reverts #957. The global `"minimatch": "^3.1.3"` resolution forced all minimatch instances to v3.x, which broke `glob@10/11` used by `@sourcebot/backend`, `@sourcebot/schemas`, and `react-email` — these require `minimatch@9+` for the `GLOBSTAR` export. All resolved versions (3.1.5, 8.0.7, 9.0.9, 10.2.4) are above the patched thresholds for CVE-2022-3517, CVE-2026-26996, and CVE-2026-27903. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughRemoved a minimatch version resolution from package.json and its corresponding changelog entry. These changes revert an earlier version pin that specified minimatch at ^3.1.3 via yarn resolutions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"minimatch": "^3.1.3"resolutionglob@10/11used by@sourcebot/backend,@sourcebot/schemas, andreact-email— these packages requireminimatch@9+for theGLOBSTARnamed exportSecurity verification
All resolved versions are above the patched thresholds for every known minimatch CVE:
minimatch@3.1.5(eslint, nodemon, glob@7)minimatch@8.0.7(glob@9 / sentry)minimatch@9.0.9(glob@10, @typescript-eslint)minimatch@10.2.4(glob@11 / backend / schemas)Test plan
yarn devstarts withoutSyntaxError: The requested module 'minimatch' does not provide an export named 'GLOBSTAR'yarn why minimatchshows all versions at or above their respective patched thresholds🤖 Generated with Claude Code
Summary by CodeRabbit