Skip to content

fix(web): Fix issue with anonymous access#984

Merged
brendan-kellam merged 2 commits intomainfrom
bkellam/fix-SOU-625
Mar 6, 2026
Merged

fix(web): Fix issue with anonymous access#984
brendan-kellam merged 2 commits intomainfrom
bkellam/fix-SOU-625

Conversation

@brendan-kellam
Copy link
Contributor

@brendan-kellam brendan-kellam commented Mar 6, 2026

I removed proxy.ts in #977, which broke some of our existing redirect behaviour. This PR adds back proxy.ts (accounting for OAuth). Ideally, when we remove the requirement of the ~ being in the URL, we'll be able to remove proxy.ts

Fixes #983

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where users were not being redirected to the homepage after clicking "continue as guest."

@github-actions

This comment has been minimized.

@brendan-kellam brendan-kellam merged commit c0653cf into main Mar 6, 2026
6 of 7 checks passed
@brendan-kellam brendan-kellam deleted the bkellam/fix-SOU-625 branch March 6, 2026 15:02
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 192afa25-5856-4dc9-9f67-fa0c2525db09

📥 Commits

Reviewing files that changed from the base of the PR and between 0504da2 and 07d7315.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • packages/web/src/proxy.ts

Walkthrough

Adds a new Next.js middleware (proxy.ts) for domain-based request routing with conditional exemptions for public routes, and documents a bug fix in the changelog for guest access redirection functionality.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md
Added fixed entry documenting correction for guest access redirection behavior.
Proxy Middleware
packages/web/src/proxy.ts
New middleware implementation handling domain normalization, public route exemptions (login, signup, oauth, etc.), and conditional URL rewriting/redirects to single-tenant domain; includes matcher config excluding API, static assets, and various public endpoints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • #970: Modifies the same proxy.ts middleware file with naming and structural changes to the proxy implementation.
  • #332: Implements related request-routing and middleware matcher logic for exempting public/static routes in the web package.
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bkellam/fix-SOU-625

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Base URL redirects to login page preventing anonymous access

1 participant