Fix issue with private repositories not being indexed#1
Merged
brendan-kellam merged 3 commits intomainfrom Oct 1, 2024
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue template for later::
Problem
When running
zoekt-mirror-githubwith the-userflag specified, private repositories are not indexed even when a valid.github-tokenfile is present.Repro steps:
~/.github-tokenwith a valid PAT tokenzoekt-mirror-github -dest data -delete -user userNameExpected:
All repositories (both public and private) associated with the user should be indexed.
Actual:
Only public repositories are indexed
How this PR fixes it:
By using a empty string for the user, the go github library will fallback on using the
users/reposendpoint instead of theusers/{user-name}/reposendpoint. For whatever reason, the latter does not return private repositories even when a authentication token is provided. The former does. Thus, this is a quick n' dirty fix that gets around this issue.From the github library:
