Conversation
…tings disclosures Bug A: add requestPolicy:"network-only" to the useQuery(LIVING_WIKI_GLOBAL_SETTINGS_QUERY) call in wiki-settings-panel.tsx. The settings page saves creds via raw authFetch (no Urql mutation), so the document cache never gets invalidated — network-only forces a fresh fetch on every panel mount, ensuring hasConfluenceCreds reflects the actual server state. Bug B: extend the Disclosure component in settings/living-wiki/page.tsx with an optional configured prop. When true, renders a green "Configured" pill beside the label; when false, a muted "Not configured" pill. Wired to all four credential groups (GitHub, GitLab, Confluence, Notion) using the respective token field as the indicator (non-empty = configured). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug A — stale Urql cache: Add
requestPolicy: "network-only"to theuseQuery(LIVING_WIKI_GLOBAL_SETTINGS_QUERY)call inwiki-settings-panel.tsx. The/settings/living-wikipage saves credentials via rawauthFetch(no Urql mutation), so the document cache never gets invalidated. Without this change, a user who lands on a repo page before saving creds getsconfluenceToken: nullcached; returning after saving still gets the stale null from the cache, leaving the Confluence sink grayed out with "(credentials not configured)".network-onlyforces a fresh server fetch on every panel mount.Bug B — no configured-state indicator: Extend the
Disclosurecomponent insettings/living-wiki/page.tsxwith an optionalconfigured?: booleanprop. Whentrue, renders a green "Configured" pill beside the label; whenfalse, a muted "Not configured" pill. Applied to all four credential groups (GitHub, GitLab, Confluence, Notion) using the respective token field as the indicator. The disclosure does not auto-open on save — only the badge changes, giving the user instant confirmation that save worked without disrupting their scroll position.Test plan
cd web && npm run lint— clean (one pre-existing warning inImproveLabelsButton.tsxonly)cd web && npm run build— clean🤖 Generated with Claude Code