ux: keybindings for branch rename (F2) and close Blame and FileHistories modal windows (ESC) #2294
Closed
asliturk wants to merge 2 commits intosourcegit-scm:developfrom
Closed
ux: keybindings for branch rename (F2) and close Blame and FileHistories modal windows (ESC) #2294asliturk wants to merge 2 commits intosourcegit-scm:developfrom
asliturk wants to merge 2 commits intosourcegit-scm:developfrom
Conversation
Collaborator
|
I have no questions about renaming keybindings. But I do not like using |
Author
|
I just realized they are not modal. But they feel like they are. I always feel like I should be able to close them with ESC. There is no key combination to close these windows, would Command+F4 (Alt+F4) be more appropriate? |
love-linger
added a commit
that referenced
this pull request
May 8, 2026
Co-authored-by: Hüseyin Aslıtürk <huseyin@asliturk.com> Signed-off-by: leo <longshuang@msn.cn>
Collaborator
|
I do not like to add a keybindings to close a normal window. PS: You can already use And I've pushed a commit that adds the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.