Skip to content

fix: null check for RevisionFileSearchSuggestion on key down#2501

Merged
love-linger merged 1 commit into
sourcegit-scm:developfrom
JC-Chung:fix/null-revision-file-search-suggestion
Jul 1, 2026
Merged

fix: null check for RevisionFileSearchSuggestion on key down#2501
love-linger merged 1 commit into
sourcegit-scm:developfrom
JC-Chung:fix/null-revision-file-search-suggestion

Conversation

@JC-Chung

Copy link
Copy Markdown
Contributor

RevisionFileSearchSuggestion is initialized to null and reset to
null by CancelRevisionFileSuggestions. Pressing Up or Down in the
revision file search box calls .Count on a null reference, causing a crash.

Fix by using ?.Count instead of .Count.

@love-linger love-linger self-assigned this Jul 1, 2026
@love-linger love-linger added the bug Something isn't working label Jul 1, 2026
@love-linger love-linger merged commit b4201ed into sourcegit-scm:develop Jul 1, 2026
14 checks passed
@JC-Chung JC-Chung deleted the fix/null-revision-file-search-suggestion branch July 1, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants