This repository was archived by the owner on Mar 18, 2024. It is now read-only.
feat: add "Fuzzy" badge to returned def/ref locations #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Jan 6, 2019
This lets extensions' location providers (definition/reference/etc. providers) associate context data with each location, and also contribute actions that are shown selectively in the file title for location matches shown in the panel. Together, these new features allow the basic-code-intel extension to add "Fuzzy" badges to defs/refs in the panel. This fixes sourcegraph/sourcegraph#1174. It would also enable things like: - Showing a "source" badge on cross-repository reference results explaining how the reference was found (eg by looking up dependents on npm) - Showing the type of reference (eg denoting some references as "Assignments", some as "Calls", some as "References", etc.) - Adding an action to "hide" or "always ignore" the reference - Adding an action to add the match to a saved list - Adding an action for users to say "This was useful" or "This was not useful" (eg for a code examples extension) See sourcegraph/code-intel-extensions#10 for an example of how extensions can use this new API.
lguychard
approved these changes
Jan 7, 2019
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Jan 8, 2019
This lets extensions' location providers (definition/reference/etc. providers) associate context data with each location, and also contribute actions that are shown selectively in the file title for location matches shown in the panel. Together, these new features allow the basic-code-intel extension to add "Fuzzy" badges to defs/refs in the panel. This fixes sourcegraph/sourcegraph#1174. It would also enable things like: - Showing a "source" badge on cross-repository reference results explaining how the reference was found (eg by looking up dependents on npm) - Showing the type of reference (eg denoting some references as "Assignments", some as "Calls", some as "References", etc.) - Adding an action to "hide" or "always ignore" the reference - Adding an action to add the match to a saved list - Adding an action for users to say "This was useful" or "This was not useful" (eg for a code examples extension) See sourcegraph/code-intel-extensions#10 for an example of how extensions can use this new API.
Contributor
|
Closing in favor of #41 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.