This repository was archived by the owner on Mar 18, 2024. It is now read-only.
Add an "Imprecise results" label to references #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
This was referenced Mar 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are often times confused why imprecise references are shown in the references panel after clicking "Find references". This happens for languages that do not have a language server and for Sourcegraph instances that don't have a language server deployed.
This adds an "Imprecise results" label (technically an action) to the references panel. Here's what it looks like when you haven't set up a language server yet:
When there is no language server for the current language, the second sentence is dropped.
When you have the
{go,typescript,python}.serverUrlset, the label is not shown.