This repository was archived by the owner on Mar 18, 2024. It is now read-only.
feat: use new extension APIs for better UX #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a panel action "Show/hide fuzzy matches" to references/definitions panel - Default to using symbols locally - Add an action to switch between using symbols locally - Coexist with precise code intelligence better - Only use old toggle action (that disables all `langserver/*` extensions) on pre-3.0 versions of Sourcegraph These improvements are intended to make it possible to enable basic code intel for all users on Sourcegraph.com.
13 tasks
lguychard
approved these changes
Dec 5, 2018
| function observableOrPromiseCompat<T>( | ||
| result: Observable<T> | Promise<T> | ||
| ): sourcegraph.ProviderResult<T> { | ||
| // HACK: Earlier extension API versions did not support providers returning observables. We can detect whether |
Contributor
There was a problem hiding this comment.
We should plan to handle the issue of extension API breakage differently - IMO there should be no backwards compatibility handling in extension code, it should be handled at the registry/extension host level.
eg.:
- If the user has activated the Sourcegraph extension E, which is only compatible with extension API vN, and his browser extension packages extension API vN+1, he receives a notification that "Incompatible extension E could not be activated"
- If the user's browser extension packages extension API vN, the extension registry will provide the latest version of E that was compatible with extension API vN, even if the very latest version of E on the registry was coded against vN+1
Member
Author
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
langserver/*extensions) on pre-3.0 versions of SourcegraphThese improvements are intended to make it possible to enable basic code intel for all users on Sourcegraph.com.
fixes https://github.com/sourcegraph/sourcegraph/issues/1175