This repository was archived by the owner on Nov 25, 2021. It is now read-only.
fix: Highlight only when response #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijsnow
force-pushed
the
highlight-only-when-response
branch
from
0d8123b to
3706353
Compare
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 64.98% 65.14% +0.15%
==========================================
Files 15 15
Lines 634 634
Branches 169 169
==========================================
+ Hits 412 413 +1
+ Misses 222 221 -1
Continue to review full report at Codecov.
|
felixfbecker
approved these changes
Aug 20, 2018
|
🎉 This PR is included in version 3.7.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #45, we didn't highlight the hovered token until we got a hover response. Otherwise we'd highlight every single token including whitespace and comments even if there's no hover information. This PR fixes that regression while keeping the improvements from #45 .