This repository was archived by the owner on Nov 25, 2021. It is now read-only.
fix: correct position adjusting observable usage #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 66.08% 64.98% -1.11%
==========================================
Files 15 15
Lines 631 634 +3
Branches 165 169 +4
==========================================
- Hits 417 412 -5
- Misses 214 222 +8
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python language server responds with contents but not a range sometimes. This means that we can end up with tooltip data and the tooltip displayed but no token highlighting. This PR rearranges some stuff to more robustly handle this and still adjust the position each time if necessary.