Skip to content
This repository was archived by the owner on Nov 25, 2021. It is now read-only.

feat: use react-loading-spinner #33

Merged
nicksnyder merged 4 commits into from
Aug 2, 2018
Merged

feat: use react-loading-spinner #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfc0cfb
feat: use css loader
nicksnyder Aug 1, 2018
8bdf480
feat: use react-loading-spinner
nicksnyder Aug 2, 2018
afacc32
fix: css
nicksnyder Aug 2, 2018
eb9c7cc
chore: relative at top
nicksnyder Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"author": "Felix Becker <felix@sourcegraph.com>",
"dependencies": {
"@sourcegraph/event-positions": "0.0.1",
"@sourcegraph/icons": "^1.15.0",
"@sourcegraph/react-loading-spinner": "0.0.2",
"highlight.js": "^9.12.0",
"lodash": "^4.17.10",
"marked": "^0.4.0",
Expand Down
2 changes: 2 additions & 0 deletions src/HoverOverlay.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import '../node_modules/@sourcegraph/react-loading-spinner/lib/LoadingSpinner.css';

.hover-overlay {
position: absolute;
width: 32rem;
Expand Down
6 changes: 3 additions & 3 deletions src/HoverOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Loader from '@sourcegraph/icons/lib/Loader'
import { LoadingSpinner } from '@sourcegraph/react-loading-spinner'
import { castArray, noop, upperFirst } from 'lodash'
import AlertCircleOutlineIcon from 'mdi-react/AlertCircleOutlineIcon'
import CloseIcon from 'mdi-react/CloseIcon'
Expand Down Expand Up @@ -121,7 +121,7 @@ export const HoverOverlay: React.StatelessComponent<HoverOverlayProps> = ({
<div className="hover-overlay__contents">
{hoverOrError === LOADING ? (
<div className="hover-overlay__row hover-overlay__loader-row">
<Loader className="icon-inline" />
<LoadingSpinner className="icon-inline" />
</div>
) : isErrorLike(hoverOrError) ? (
<div className="hover-overlay__row hover-overlay__hover-error alert alert-danger">
Expand Down Expand Up @@ -181,7 +181,7 @@ export const HoverOverlay: React.StatelessComponent<HoverOverlayProps> = ({
className="btn btn-secondary hover-overlay__action e2e-tooltip-j2d"
onClick={onGoToDefinitionClick ? transformMouseEvent(onGoToDefinitionClick) : undefined}
>
Go to definition {definitionURLOrError === LOADING && <Loader className="icon-inline" />}
Go to definition {definitionURLOrError === LOADING && <LoadingSpinner className="icon-inline" />}
</ButtonOrLink>
<ButtonOrLink
linkComponent={linkComponent}
Expand Down