This repository was archived by the owner on Nov 25, 2021. It is now read-only.
Add allowed tags and attributes for extensions #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The markdown is passed to [marked](https://marked.js.org/) and then to [sanitize-html](https://www.npmjs.com/package/sanitize-html). In order to get the needed tags, I put my needed markdown into [marked's demo](https://marked.js.org/demo) and looked at the HTML they provided.
Contributor
Author
|
As context, here is the original issue I filed |
Compared to [https://github.com/sourcegraph/codeintellify/blob/a3274229d34c72e0ad3a128f60a2065e7b1015ff/src/helpers.ts#L108](https://github.com/sourcegraph/codeintellify/blob/a3274229d34c72e0ad3a128f60a2065e7b1015ff/src/helpers.ts#L108) and added comma (Travis broke on prettier)
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 72.83% 77.01% +4.18%
==========================================
Files 14 14
Lines 611 609 -2
Branches 165 168 +3
==========================================
+ Hits 445 469 +24
+ Misses 166 140 -26
Continue to review full report at Codecov.
|
src/helpers.ts
Outdated
| // <span class="hljs-keyword"> | ||
| // <code class="language-javascript"> | ||
| allowedTags: [...sanitize.defaults.allowedTags, 'span'], | ||
| allowedTags: [...sanitize.defaults.allowedTags, 'span', 'h4', 'a', 'p', 'strong', 'details', 'summary'], |
Contributor
There was a problem hiding this comment.
Suggested change
| allowedTags: [...sanitize.defaults.allowedTags, 'span', 'h4', 'a', 'p', 'strong', 'details', 'summary'], | |
| allowedTags: [...sanitize.defaults.allowedTags, 'span', 'details', 'summary'], |
h4, p, strong are all already in defaults.allowedTags: https://sourcegraph.com/github.com/punkave/sanitize-html/-/blob/src/index.js#L572
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markdown is passed to marked and then to sanitize-html. In order to get the needed tags, I put my needed markdown into marked's demo and looked at the HTML they provided.