This repository was archived by the owner on Mar 4, 2021. It is now read-only.
add an optional upload argument for an associated index ID #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efritz
approved these changes
Jan 18, 2021
| qs.SetOptionalBool("done", args.done) | ||
|
|
||
| if args.associatedIndexID != nil { | ||
| qs.SetInt("associatedIndexID", *args.associatedIndexID) |
There was a problem hiding this comment.
Just for consistency, do we have other lowerCamelCasedQueryParams that end in ID? If we do, is it ID or Id?
There was a problem hiding this comment.
Line 254 in 03d694c
Looks like Id is used just above.
There was a problem hiding this comment.
woorps completely misread this comment, thought it was confirming ID was right lol
There was a problem hiding this comment.
👅 I figured.
"thumbs up won't fix"
40 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.