Skip to content

chore: update README.md#32

Merged
valerybugakov merged 1 commit intomainfrom
vb/update-readme
Sep 28, 2021
Merged

chore: update README.md#32
valerybugakov merged 1 commit intomainfrom
vb/update-readme

Conversation

@valerybugakov
Copy link
Copy Markdown
Member

@valerybugakov valerybugakov commented Sep 28, 2021

Changes

  • Add post codemod steps to the globalCssToCssModule README.md
  • Disable prettier-eslint by default
  • Fix one corner-case in the codemod.

@valerybugakov valerybugakov self-assigned this Sep 28, 2021
@valerybugakov valerybugakov requested a review from umpox September 28, 2021 08:55
@valerybugakov valerybugakov marked this pull request as ready for review September 28, 2021 08:55

Currently, it's quite slow because a new ESLint instance is initialized for each file. Consider running `eslint --fix` after the codemod if you're changing a lot of files in one command.

## Post codemod steps in the Sourcegraph repo
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instructions are great 👏

@valerybugakov valerybugakov merged commit 92d5088 into main Sep 28, 2021
@valerybugakov valerybugakov deleted the vb/update-readme branch September 28, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants