add codeinsights-db deployment #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 19, 2021 15:27
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
This was referenced Feb 19, 2021
emidoots
pushed a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Feb 19, 2021
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
emidoots
pushed a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Feb 19, 2021
davejrt
approved these changes
Feb 19, 2021
daxmc99
reviewed
Feb 19, 2021
| cpus: 4 | ||
| mem_limit: "2g" | ||
| environment: | ||
| - POSTGRES_PASSWORD=password |
Contributor
There was a problem hiding this comment.
Our other db's do not set a password (at least at the docker-compose YAML level), why do we set one here?
Member
Author
There was a problem hiding this comment.
In our Postgres image we actually bake in this environment variable. We don't do it here because this is just a re-tagged TimescaleDB image.
daxmc99
reviewed
Apr 22, 2021
| - "codeinsights-db:/data/" | ||
| networks: | ||
| - sourcegraph | ||
| restart: always |
Contributor
There was a problem hiding this comment.
Is there any reason we didn't add health checks here?
Member
Author
There was a problem hiding this comment.
no good reason I can think of, probably I just forgot to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the codeinsights-db deployment, which is a TimescaleDB time series database deployment used for recording Code Insights data.
I have test both deployments start up as expected.
Fixes https://github.com/sourcegraph/sourcegraph/issues/17225
Checklist