docs: set kubernetes.io/ingress.class to null if ingressClassName is set #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…you set ingressClassName
michaellzc
approved these changes
Aug 22, 2022
Member
michaellzc
left a comment
michaellzc
left a comment
There was a problem hiding this comment.
lgtm
would you also help fixing this example? https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/examples/ingress/override.yaml
it configures annotation and ingressClassName at the same time
nicksnyder
added a commit
that referenced
this pull request
Aug 23, 2022
Fix example to follow docs added in #165
2 tasks
Contributor
Author
|
Thanks for flagging that example! Updating here: #166 |
nicksnyder
added a commit
that referenced
this pull request
Aug 23, 2022
) Fix example to follow docs added in #165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer reported issues when they tried to set
ingressClassName:The solution is to set
annotations.kubernetes.io/ingress.classtonull.This PR updates the documentation to make this more clear.
Checklist
Test plan
This is just updating the documentation.