removed minReadySeconds settings from Searcher and Symbols #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is proposed because:
minReadySecondsconfiguration in release v1.22Alternative solutions could involve making
minReadySecondsa configurable, optional helm value for these STSs, or possibly reverting these two services back to Deployments if we absolutely want to enforce this setting. The impact of removing this setting should be minimal, and we already ship other StatefulSets that do not defineminReadySecondssetting.Checklist
Test plan
helm lint charts/sourcegraph/.helm template charts/sourcegraph/ | grep -i "minReadySeconds" -B 2