Skip to content

Conversation

@jac
Copy link
Member

@jac jac commented Apr 20, 2023

The helm-unittest library was recently updated.
This change pins an older, working version until the newer version can be checked and tests updated accordingly

Test plan

Tests pass locally

@jac jac requested review from coury-clark and jdpleiness April 20, 2023 11:29
@jac jac merged commit 70db8d9 into main Apr 20, 2023
@jac jac deleted the jac/unittest-version branch April 20, 2023 14:50
coury-clark pushed a commit that referenced this pull request Apr 20, 2023
coury-clark added a commit that referenced this pull request Apr 20, 2023
* release: sourcegraph@5.0.2

* fix unittest invocation

* disable test

* disable test

* disable test

* Pin helm-unittest version (#273)

* enable tests

* rollback change

---------

Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com>
coury-clark added a commit that referenced this pull request Apr 20, 2023
* release: sourcegraph@5.0.2

* fix unittest invocation

* disable test

* disable test

* disable test

* Pin helm-unittest version (#273)

* enable tests

* rollback change

---------

Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com>
coury-clark added a commit that referenced this pull request Apr 20, 2023
* release: sourcegraph@5.0.2

* fix unittest invocation

* disable test

* disable test

* disable test

* Pin helm-unittest version (#273)

* enable tests

* rollback change

---------

Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants