Skip to content

Conversation

@jac
Copy link
Member

@jac jac commented May 3, 2023

Adds Embeddings service for Cody embeddings (disabled by default)

  • SG blobstore + external storage supported by setting .Values.embeddings.backend to appropriate values
    • Updates env vars on both the embeddings container and worker container.
    • Doesn't set on frontend despite being mentioned in docs as consensus is it's not actually needed on frontend (happy to be proven wrong)

Checklist

Test plan

Tested locally using blobstore + gcs (using EMBEDDINGS_UPLOAD_GOOGLE_APPLICATION_CREDENTIALS_FILE_CONTENT)

  • Successfully created embeddings for repositories

@jac jac requested review from keegancsmith and unknwon May 3, 2023 01:35
@jac jac changed the title Jac/embeddings Embeddings Service May 3, 2023
@unknwon unknwon requested a review from a team May 3, 2023 01:51
Copy link
Contributor

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really review much but if it works then it's great, as long as it can be used to replaced the current Cloud-specific version (so we don't end up maintaining two charts of embeddings :D

@jac jac merged commit 55e0656 into main May 3, 2023
@jac jac deleted the jac/embeddings branch May 3, 2023 12:49
@jac jac mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants