Skip to content

Conversation

@jac
Copy link
Member

@jac jac commented May 16, 2023

Changes how embeddings configuration is handled. This aligns more closely to how external blob storage is configured for code intel indexes

Test plan

Testing by deploying locally; configured to connect to a GCS bucket. Confirmed embeddings uploaded correctly.

@jac jac requested a review from jdpleiness May 16, 2023 22:14
@jac jac force-pushed the jac/embeddings-style branch from 376a876 to c585d65 Compare May 16, 2023 22:22
@jac jac enabled auto-merge (squash) May 16, 2023 22:22
Copy link
Contributor

@jdpleiness jdpleiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@jac jac merged commit bcd8cde into main May 17, 2023
@jac jac deleted the jac/embeddings-style branch May 17, 2023 13:31
@jac jac mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants