Skip to content

Conversation

@camdencheek
Copy link
Member

@camdencheek camdencheek commented Aug 23, 2023

Apparently strategy is not a valid field for StatefulSet (only Deployment). I caught this when trying to port the rendered helm template to the dotcom deployment, which uses kubectl apply rather than helm upgrade. kubectl apply returns a validation error for that field.

This fixes strategy and two other invalid fields which are ignored with helm, but get caught by the kubectl apply validator.

Checklist

Test plan

Ran the cluster locally, inspected the running service to ensure it had an update strategy of RollingUpdate

@camdencheek camdencheek marked this pull request as ready for review August 23, 2023 04:19
@camdencheek camdencheek requested a review from a team August 23, 2023 04:20
@camdencheek camdencheek enabled auto-merge (squash) August 23, 2023 04:28
@camdencheek camdencheek merged commit ca8bfbd into main Aug 23, 2023
@camdencheek camdencheek deleted the cc/fix-update-strategy branch August 23, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants