appliance: add frontend resources #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfurman
commented
Jul 26, 2024
charts/sourcegraph-appliance/templates/deployment-frontend.yaml
Outdated
Show resolved
Hide resolved
craigfurman
force-pushed
the
appliance-frontend-tweaks
branch
from
32764dd to
a5634c7
Compare
craigfurman
commented
Jul 29, 2024
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| app: sourcegraph-appliance | ||
| app: sourcegraph-appliance |
Contributor
Author
There was a problem hiding this comment.
indentation fixed - now the new backend service should actually select something 🙏
craigfurman
force-pushed
the
appliance-frontend-tweaks
branch
2 times, most recently
from
c6811f9 to
5a7916e
Compare
craigfurman
force-pushed
the
appliance-frontend-tweaks
branch
2 times, most recently
from
6617efd to
56a6749
Compare
- Add deployment for appliance-frontend. - re-point frontend service at this frontend, not the appliance backend - Add a service for the backend, and reference it in the frontend's env vars. - Fix indentation of appliance backend label. - Hardcode appliance backend container port - there's no need to change it, this is just error-prone. - Fix deployment name for self-update, and add the frontend to the self-update list (see https://linear.app/sourcegraph/issue/REL-302/self-update-should-update-appliance-frontend-too), and make it optional. - Bump chart app version
craigfurman
force-pushed
the
appliance-frontend-tweaks
branch
from
56a6749 to
c84fdad
Compare
Chickensoupwithrice
approved these changes
Jul 29, 2024
craigfurman
pushed a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Jul 30, 2024
The helm chart will configure both the backend and frontend deployments to self-update: sourcegraph/deploy-sourcegraph-helm#513 Relates to https://linear.app/sourcegraph/issue/REL-302/self-update-should-update-appliance-frontend-too
craigfurman
pushed a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Jul 30, 2024
The helm chart will configure both the backend and frontend deployments to self-update: sourcegraph/deploy-sourcegraph-helm#513 Relates to https://linear.app/sourcegraph/issue/REL-302/self-update-should-update-appliance-frontend-too
craigfurman
pushed a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Jul 31, 2024
The helm chart will configure both the backend and frontend deployments to self-update: sourcegraph/deploy-sourcegraph-helm#513 Relates to https://linear.app/sourcegraph/issue/REL-302/self-update-should-update-appliance-frontend-too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vars.
it, this is just error-prone.
self-update list (see
https://linear.app/sourcegraph/issue/REL-302/self-update-should-update-appliance-frontend-too)
Relates to https://linear.app/sourcegraph/issue/REL-293/appliance-is-packaged-in-containers-for-production and https://linear.app/sourcegraph/issue/REL-305/kick-the-tires-with-a-realistic-ingress, but does not close them.
Checklist
Test plan
See comments in https://linear.app/sourcegraph/issue/REL-305/kick-the-tires-with-a-realistic-ingress