sourcegraph: do not include frontend env var in migrator container

[michaellzc]

this can result in duplicated env var and cause weird behaviour.

Checklist

• Follow the manual testing process
• Update changelog
• Update Kubernetes update doc

Test plan

n/a

[michaellzc]

@eseliger this is what caused the broken kustomize build | kubectl apply -f when rolling out MT

[eseliger]

I have no clue about this - are there any env vars in frontend that migrator would also need? I think in the MVU case it might need things like "where's the KMS secrets" etc 🤔 But not exactly sure there. I could see this being used at customers .. 🤔

cc @sourcegraph/release

[michaellzc]

I think this is fine.

for db connection string, we don't read from frontend.env, it's always computed from the partial template

deploy-sourcegraph-helm/charts/sourcegraph/templates/frontend/sourcegraph-frontend.Deployment.yaml

Lines 52 to 61 in fde5020

	- name: migrator
	image: {{ include "sourcegraph.image" (list . "migrator") }}
	imagePullPolicy: {{ .Values.sourcegraph.image.pullPolicy }}
	args: {{- default (list "up") .Values.migrator.args | toYaml | nindent 8 }}
	env:
	{{- if not .Values.migrator.databaseAuthOverrideEnvVars }}
	{{- include "sourcegraph.databaseAuth" (list . "pgsql" "PG") | nindent 8 }}
	{{- include "sourcegraph.databaseAuth" (list . "codeIntelDB" "CODEINTEL_PG") | nindent 8 }}
	{{- include "sourcegraph.databaseAuth" (list . "codeInsightsDB" "CODEINSIGHTS_PG") | nindent 8 }}
	{{- end }}

not sure about the KMS example?

[DaedalusG]

I'm concerned this might be used in autoupgrade -- reading 👀 brain is cooked from the release stuff

[DaedalusG]

Alright I think these are all we need:

      - PGHOST=pgsql
      - PGPORT=5432
      - PGUSER=sg
      - PGPASSWORD=sg
      - PGDATABASE=sg
      - PGSSLMODE=disable

      - CODEINTEL_PGHOST=codeintel-db
      - CODEINTEL_PGPORT=5432
      - CODEINTEL_PGUSER=sg
      - CODEINTEL_PGPASSWORD=sg
      - CODEINTEL_PGDATABASE=sg
      - CODEINTEL_PGSSLMODE=disable

      - CODEINSIGHTS_PGHOST=codeinsights-db
      - CODEINSIGHTS_PGPORT=5432
      - CODEINSIGHTS_PGUSER=postgres
      - CODEINSIGHTS_PGPASSWORD=password
      - CODEINSIGHTS_PGDATABASE=postgres
      - CODEINSIGHTS_PGSSLMODE=disable

And those should all be generated by this

[michaellzc]

yes, thank you

[marcleblanc2]

This was a breaking change, which impacted self-hosted customers upgrading, which should have been communicated to them in advance of upgrading >= v5.8