Release update + tooling QA #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jhchabran
requested review from
BolajiOlajide,
DaedalusG,
burmudar and
jdpleiness
burmudar
approved these changes
Mar 25, 2024
Contributor
burmudar
left a comment
burmudar
left a comment
There was a problem hiding this comment.
Minor word fixups but tested and it works 👍🏼
Contributor
|
I'll wait for one additional review otherwise I'll merge EOB |
BolajiOlajide
approved these changes
Mar 25, 2024
Contributor
Ooopsie. Sorry, I jumped the gun here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of sourcegraph/deploy-sourcegraph-docker#1008, see the description over there, it's exactly the same logic.
Description
Checklist
Test plan
QA for the changes in that PR: same as the docker variant, mutiple runs
QA for the result: compared the PR file by file against https://github.com/sourcegraph/deploy-sourcegraph-k8s/pull/101/files