Skip to content

Add imagepullsecrets component with example #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2023
Merged

Add imagepullsecrets component with example #19

merged 2 commits into from
Mar 13, 2023

Conversation

@abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Mar 13, 2023 •
edited
Loading

Description

RE: https://sourcegraph.slack.com/archives/C02E4HE42BX/p1678721977364219

We have a component in Kustomize for using a private registry, but it looks like that component doesn’t account for adding image pull secrets. Is the customer (and am I) missing something here?

User can add a patch to add new field to all resources, for example:

patches:
  - patch: |-
      - op: add
        path: /spec/template/spec/imagePullSecrets
        value:
          name: registrykey
    target:
      group: apps
      kind: StatefulSet|Deployment|DaemonSet
      version: v1

This PR turns this suggested patch into a component for easier configuration.

Checklist

Test plan

  1. Run kubectl kustomize examples/demo/private-registry -o test.yaml from the root of this repository in this branch
  2. check the output file test.yamlto see the imagePullSecrets field has been added to all resources with value from buildConfig.yaml

@abeatrix abeatrix requested a review from scjohns March 13, 2023 20:30
@abeatrix abeatrix mentioned this pull request Mar 13, 2023
Merged
scjohns
scjohns approved these changes Mar 13, 2023
View reviewed changes
Copy link

@scjohns scjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick turnaround here

@abeatrix abeatrix merged commit 6e45f6a into main Mar 13, 2023
abeatrix added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this pull request Mar 13, 2023
@abeatrix
docs: add imagepullsecrets kustomize guide (#49250)
53f2a96 
Add docs for new component added in
sourcegraph/deploy-sourcegraph-k8s#19


## Test plan

<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->

Run docs locally:


![image](https://user-images.githubusercontent.com/68532117/224827650-377c0c0f-d71d-4716-ae89-aadee0817423.png)
@abeatrix abeatrix deleted the bee/imagepullsecrets branch March 13, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@scjohns scjohns scjohns approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abeatrix @scjohns