Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Conversation

@beyang
Copy link
Member

@beyang beyang commented Apr 14, 2020

@beyang beyang requested a review from emidoots April 14, 2020 18:44
@emidoots
Copy link
Member

Note: when you move this over, you should use an almost identical build.sh as https://github.com/sourcegraph/sourcegraph/blob/master/docker-images/grafana/build.sh

This will ensure the image gets built on CI automatically, as well as that it gets versioned alongside Sourcegraph (jaeger-all-in-one:3.15.0 / jaeger-all-in-one:insiders NOT jaeger-all-in-one:1.17.1).

You should also make sure your Dockerfile has these labels: https://github.com/sourcegraph/sourcegraph/blob/master/docker-images/prometheus/Dockerfile#L20-L30

@beyang beyang merged commit d081b91 into master Apr 15, 2020
@beyang beyang deleted the bl/jaeger-non-root-tmp branch April 15, 2020 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants