feat: update docs for commit signing #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
docs/admin/config/batch_changes.mdx
Outdated
|
|
||
| ### Commit signing with SSH Keys (GitLab and GitHub) | ||
|
|
||
| <Callout type="note"> This feature is supported only in Sourcegraph versions 6.2 or more.</Callout> |
There was a problem hiding this comment.
Nit: How about "or later" instead of "or more"?
There was a problem hiding this comment.
Hm, after finishing reading this diff I see we have "or more" in other parts of the docs as well. I'm curious what Maedah's stance is
There was a problem hiding this comment.
@MaedahBatool do we have a standard here?
There was a problem hiding this comment.
hey @bahrmichael we have the following formats:
- v6.2 or more
- v6.2+
|
@MaedahBatool This PR is now ready for review. The feature will be available to customers with the 6.2 release. Should we target main, or a different branch? |
LeweyM
reviewed
Mar 18, 2025
MaedahBatool
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SRCH-1746