deepsearch/api: remove 'failed' conversation status#1457
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bobheadxi
force-pushed
the
deepsearch-api-remove-failed-status
branch
from
17e379e to
3319595
Compare
eseliger
approved these changes
Nov 27, 2025
bobheadxi
added a commit
that referenced
this pull request
Dec 8, 2025
We require this field here: https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph@486b3e5807a62c079018f8eb7cc7f7426b433a7f/-/blob/cmd/frontend/internal/deepsearchapi/handler_deepsearch.go?L390-393 IMO ideally, one shouldn't have to specify the ID in both the body and the URL, but it's hard to remove this field as it seems we use external API types as internal DB schemas: https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph@486b3e5807a62c079018f8eb7cc7f7426b433a7f/-/blob/internal/database/deepsearch.go?L40%3A2-40%3A16 . So similarly to #1457, just opted to document it here for now. Left a note about this in https://linear.app/sourcegraph/issue/CU-1495/deep-search-api-housekeeping#comment-a991836e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This status doesn't exist. After poking at it for a while in https://github.com/sourcegraph/sourcegraph/pull/7964 I've decided the change is a bit too pervasive (since we store external API shape directly into DB), and it's probably better to just fix the docs.
Sadly, it looks like there's no published schema for this, so I also added what the error behaviour is supposed to be.
Part of https://linear.app/sourcegraph/issue/CU-1495/api-housekeeping