Skip to content

Conversation

@burmudar
Copy link
Contributor

@burmudar burmudar commented Feb 4, 2025

Some changelog entries have OPTIONAL; info at ... which should actually be removed by an engineer when it gets merged but it is left over.

@burmudar burmudar requested review from a team February 4, 2025 21:52
@burmudar burmudar self-assigned this Feb 4, 2025
@vercel
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:53pm

@burmudar burmudar requested a review from a team February 4, 2025 21:52
@burmudar burmudar merged commit 7846272 into main Feb 4, 2025
5 checks passed
@burmudar burmudar deleted the wb/changelog-cleanup branch February 4, 2025 21:54
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should get the changelog bot to complain if they leave this in (and if they devs don't make there beds in the morning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants