Skip to content

Callout UI Improved #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Callout UI Improved #984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b994786
Fixed link color in light mode
zahidalidev Feb 14, 2025
5f80cb5
Updated callout colors
zahidalidev Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/components/mdx/Callout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,27 @@ import {
LightBulbIcon,
ExclamationTriangleIcon
} from '@heroicons/react/24/outline';
import { NotebookPen } from 'lucide-react';

const styles = {
note: {
container:
'border-sky-500/20 bg-sky-50/50 dark:border-sky-500/30 dark:bg-sky-500/10',
'border-sky-500/20 bg-sky-50/50 dark:border-[#002533] dark:bg-[#001118]',
icon: 'text-sky-500',

body: 'text-sky-800 [--tw-prose-background:theme(colors.sky.50)] prose-a:text-sky-900 prose-code:text-sky-900 dark:text-slate-300 dark:prose-code:text-slate-300'
body: 'text-sky-800 [--tw-prose-background:theme(colors.sky.50)] prose-a:text-sky-900 prose-code:text-sky-900 dark:text-[#85cfe9] dark:prose-code:text-[#85cfe9]'
},
info: {
container:
'dark:bg-slate-900 border-slate-300 dark:border-slate-200/20',
icon: 'text-inherit',
body: 'text-sky-800 [--tw-prose-background:theme(colors.sky.50)] prose-a:text-sky-900 prose-code:text-sky-900 dark:text-slate-300 dark:prose-code:text-slate-300'
'border-sky-500/20 bg-sky-50/50 dark:border-[#002533] dark:bg-[#001118]',
icon: 'text-sky-500',
body: 'text-sky-800 [--tw-prose-background:theme(colors.sky.50)] prose-a:text-sky-900 prose-code:text-sky-900 dark:text-[#85cfe9] dark:prose-code:text-[#85cfe9]'
},
tip: {
container:
'border-sky-500/20 bg-sky-50/50 dark:border-sky-500/30 dark:bg-sky-500/10',
'border-sky-500/20 bg-sky-50/50 dark:border-[#002533] dark:bg-[#001118]',
icon: 'text-sky-500',
body: 'text-sky-800 [--tw-prose-background:theme(colors.sky.50)] prose-a:text-sky-900 prose-code:text-sky-900 dark:text-slate-300 dark:prose-code:text-slate-300'
body: 'text-sky-800 [--tw-prose-background:theme(colors.sky.50)] prose-a:text-sky-900 prose-code:text-sky-900 dark:text-[#85cfe9] dark:prose-code:text-[#85cfe9]'
},
warning: {
container:
Expand All @@ -36,7 +37,7 @@ const styles = {

const icons = {
note: (props: {className?: string}) => (
<InformationCircleIcon className={props.className} />
<NotebookPen className={props.className} />
),
info: (props: {className?: string}) => (
<InformationCircleIcon className={props.className} />
Expand Down
2 changes: 1 addition & 1 deletion src/components/mdx/CustomLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const CustomLink: React.FC<CustomLinkProps> = ({
// Handling external links
if (href.startsWith('http')) {
return (
<a href={href} target="_blank" rel="noopener noreferrer" {...rest} className='no-underline hover-underline'>
<a href={href} target="_blank" rel="noopener noreferrer" {...rest} className='no-underline text-vermilion-07'>
{children}
</a>
);
Expand Down