Skip to content

Conversation

@loujar
Copy link
Contributor

@loujar loujar commented Feb 17, 2025

added note to configure KUBERNETES_RUN_AS_USER & KUBERNETES_RUN_AS_GROUP for native k8s executors as it is now required to explicitly configure these ENVs when deploying native k8s executors

Follow up doc change for sourcegraph/deploy-sourcegraph-helm#618

Pull Request approval

You will need to get your PR approved by at least one member of the Sourcegraph team. For reviews of docs formatting, styles, and component usage, please tag the docs team via the #docs Slack channel.

@vercel
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:02pm

@loujar
Copy link
Contributor Author

loujar commented Feb 17, 2025

Actually realizing this is not explicitly required since sourcegraph/deploy-sourcegraph-helm#618 set the default value to "blank", which removes the requirement to explicitly configure UID / GUID

Having those settings commented out causes KUBERNETES_RUN_AS_USER and KUBERNETES_RUN_AS_GROUP in charts/sourcegraph-executor/k8s/templates/executor.ConfigMap.yaml to be blank, which is the new default value.

@loujar loujar closed this Feb 17, 2025
auto-merge was automatically disabled February 17, 2025 19:05

Pull request was closed

@loujar loujar deleted the lsj/executors-runasuser branch February 17, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants