Merged
Conversation
mrnugget
approved these changes
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the error that is returned in
init()gets outputted to stderr, while the problems that were printed just before it were outputted to stderr. On a terminal one won't notice it, but once you have scripts/commands that read from stderr and stdout seperately and do different things, the output gets disjointed.As can be seen here https://sourcegraph.slack.com/archives/C01N83PS4TU/p1664207483448289
Test plan
sourcegraph/sourcegraph./docsite check >stdout.txt 2>stderr.txtstdout.txtshould be empty andstderr.txtshould have all the error output