This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Adding an error check in handleHoverGodef #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an error check to avoid crash while accessing the result of typecheck when there is an error generated.
Encountered a panic during hover. I don't have a way to reproduce it consistently. However I think this check is necessary. Please let me know otherwise. Posting the panic st.
Signed-off-by: Abhinandan Prativadi aprativadi@fb.com