This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Fix workspace/xreferences #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfbecker
force-pushed
the
fix-workspace-xreferences
branch
from
442f4e3 to
ab369d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 58.85% 59.43% +0.58%
==========================================
Files 14 14
Lines 2129 2135 +6
Branches 350 349 -1
==========================================
+ Hits 1253 1269 +16
+ Misses 726 713 -13
- Partials 150 153 +3
Continue to review full report at Codecov.
|
felixfbecker
commented
Jun 4, 2017
| return this._getPackageDescriptor(uri) | ||
| .mergeMap(packageDescriptor => { | ||
| return Observable.from(this._getPackageDescriptor(uri, span)) | ||
| .filter(packageDescriptor => !!(packageDescriptor && packageDescriptor.name === params.query.package!.name!)) |
Contributor
Author
There was a problem hiding this comment.
there should be a test for a query with PackageDescriptor.
felixfbecker
force-pushed
the
fix-workspace-xreferences
branch
from
ab369d9 to
f51c294
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.