This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Apply chore improvements; update latest ide version#2023
Merged
mkondratek merged 5 commits intomainfrom Nov 4, 2024
Merged
Conversation
pkukielka
reviewed
Aug 9, 2024
| - run: | | ||
| echo "RELEASE_VERSION=$(./scripts/version-from-git-tag.sh)" >> $GITHUB_ENV | ||
| - run: echo "Publishing version $RELEASE_VERSION" | ||
| - run: git tag -a "RELEASE_VERSION" -m "RELEASE_VERSION" && git push origin "$RELEASE_VERSION" |
Contributor
There was a problem hiding this comment.
I don't think it will work on CI
Contributor
Author
There was a problem hiding this comment.
you are right. let's stick to the current approach then
Contributor
Author
pkukielka
suggested changes
Aug 9, 2024
Contributor
pkukielka
left a comment
pkukielka
left a comment
There was a problem hiding this comment.
I don't think it will work on CI
mkondratek
changed the title
mkondratek
force-pushed
the
mkondratek/chore/improve-scripts
branch
from
f3bb2b1 to
04b64f4
Compare
mkondratek
changed the title
mkondratek
force-pushed
the
mkondratek/chore/improve-scripts
branch
from
6638137 to
a0ee32e
Compare
pkukielka
reviewed
Nov 4, 2024
| - run: yarn global add pnpm@8.6.7 | ||
| - run: | | ||
| echo "RELEASE_VERSION=$(./scripts/version-from-git-tag.sh)" >> $GITHUB_ENV | ||
| - run: echo "Publishing version $RELEASE_VERSION" |
Contributor
Author
There was a problem hiding this comment.
this step was redundant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need the GitHub releases and their links to look nice. A stable release should not include-nightlyin the link. This PR will automatically push a new tag without the suffix so we will be able to use it to generate the release notes.We cannot push from CI (without creating a token and setting it as a secret). Let's stick to the present process (manually push stable tag when needed).
Btw, I added a few minor improvements.
Test plan
To test these changes we will need to do a stable release 😃