This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Do not run EDT code in CodyFixHighlightPass:doCollectInformation#2289
Merged
Do not run EDT code in CodyFixHighlightPass:doCollectInformation#2289
Conversation
pkukielka
commented
Sep 13, 2024
| // >= HighlightSeverity.INFO | ||
| myHighlights.mapNotNull { | ||
| try { | ||
| val range = document.codyRange(it.startOffset, it.endOffset) |
Contributor
Author
There was a problem hiding this comment.
codyRange already contains the same check.
pkukielka
commented
Sep 13, 2024
| break | ||
| } | ||
|
|
||
| val range = |
Contributor
Author
There was a problem hiding this comment.
No need to recompute the same thing again
mkondratek
approved these changes
Sep 13, 2024
Contributor
mkondratek
left a comment
mkondratek
left a comment
There was a problem hiding this comment.
tried it a few times.
before this change I was able to reproduce it
after this change I am not able to repro it
lgtm
pkukielka
added a commit
that referenced
this pull request
Sep 19, 2024
Fixes #2287 ## Changes Looks like we cannot do EDT actions in the `CodyFixHighlightPass:doCollectInformation` or we are risking a deadlock. ## Test plan It's a bit hard to test deterministically but for me adding and removing few special characters on an empty file was triggering IDE crash pretty quickly (10-20 sec). I used combination of: `Option + \` (`«`) `Option + P` (`Ļ`) `Backspace` In a random order. Timing matters, keep changing the tempo of the keystrokes.
pkukielka
added a commit
that referenced
this pull request
Sep 19, 2024
Fixes #2287 ## Changes Looks like we cannot do EDT actions in the `CodyFixHighlightPass:doCollectInformation` or we are risking a deadlock. ## Test plan It's a bit hard to test deterministically but for me adding and removing few special characters on an empty file was triggering IDE crash pretty quickly (10-20 sec). I used combination of: `Option + \` (`«`) `Option + P` (`Ļ`) `Backspace` In a random order. Timing matters, keep changing the tempo of the keystrokes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2287
Changes
Looks like we cannot do EDT actions in the
CodyFixHighlightPass:doCollectInformationor we are risking a deadlock.Test plan
It's a bit hard to test deterministically but for me adding and removing few special characters on an empty file was triggering IDE crash pretty quickly (10-20 sec).
I used combination of:
Option + \(«)Option + P(Ļ)BackspaceIn a random order.
Timing matters, keep changing the tempo of the keystrokes.